test: add type script plugin e2e #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Code PushUp😟 Code PushUp report has regressed – compared current commit f0bee13 with previous commit c677fa2. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories
👎 3 groups regressed, 👎 5 audits regressed, 12 audits changed without impacting score🗃️ Groups
15 other groups are unchanged. 🛡️ Audits
579 other audits are unchanged. |
BioPhoton
added a commit
that referenced
this pull request
Mar 21, 2025
**This PR includes:** - docs - plugin exports - demo usage - @matejchalk any idea how we can use it best on our code? **Followup:** - #974 --------- Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
reviewed
Mar 25, 2025
Comment on lines
+72
to
+74
| expect( | ||
| omitVariableReportData(reportJson, { omitAuditData: true }), | ||
| ).toMatchFileSnapshot('__snapshots__/typescript-plugin-json-report.json'); |
There was a problem hiding this comment.
Why are you omitting audit data? It significantly reduces test coverage - the runner output isn't being asserted at all. Unlike the Lighthouse plugin, I believe the audit outputs shoud be deterministic in this case.
Comment on lines
+8
to
+21
| plugins: [ | ||
| await typescriptPlugin({ | ||
| tsConfigPath: 'tsconfig.json', | ||
| }), | ||
| ], | ||
| categories: [ | ||
| { | ||
| slug: 'typescript-quality', | ||
| title: 'Typescript', | ||
| refs: await getCategoryRefsFromGroups({ | ||
| tsConfigPath: 'tsconfig.json', | ||
| }), | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Wasn't tsConfigPath renamed? I guess you can omit it anyway, since tsconfig.json is the default value.
| }, | ||
| test: { | ||
| reporters: ['basic'], | ||
| testTimeout: 120_000, |
There was a problem hiding this comment.
In #976 you reduced the timeouts well below 2 mins for all E2E tests. I'm guessing the TS plugin could have a much lower timeout.
Comment on lines
+7
to
+13
| resolve: { | ||
| alias: { | ||
| '@code-pushup/test-nx-utils': '../../test-nx-utils/index.js', | ||
| '@code-pushup/test-setup': '../../test-setup/index.js', | ||
| '@code-pushup/test-utils': '../../test-utils/index.js', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Is this configuration needed? Other E2E project's don't have it and tsconfigPathAlias is being used already.
Co-authored-by: Matěj Chalk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percondition:
This PR includes: